Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a CI workflow for testing the mock server and refactors the server implementation to use a cleaner abstraction for replay functionality.
- Adds GitHub Actions workflow to automatically run mock server tests on PRs
- Refactors server request handling to use the
replay()helper function instead of manual Polly setup/teardown - Enhances the
replay()function to support generic return types for better type safety
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test_mock_server.yml |
New CI workflow that runs mock server tests using Bun on pull requests |
resources/mock-server/package.json |
Adds test script to run vitest via Bun |
resources/mock-server/src/server.ts |
Refactored to use replay() helper function, removing manual Polly setup/teardown code |
resources/mock-server/src/index.ts |
Enhanced replay() function with generic type parameter and return value support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joe-p
force-pushed
the
ci/mock_server_test
branch
from
82d9393 to
802c9b2
Compare
lempira
requested changes
Nov 13, 2025
lempira
reviewed
Nov 13, 2025
lempira
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also included a minor refactor to use the replay function in the server